Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix appearance of spinner buttons in number input #954

Merged
merged 2 commits into from
Jan 15, 2025
Merged

[Bug] Fix appearance of spinner buttons in number input #954

merged 2 commits into from
Jan 15, 2025

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Jan 15, 2025 •
edited
Loading

Description

  • Ensure that the custom CSS for the Slider no longer interferes with the visibility of the spinner buttons in number inputs

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen changed the title [Bug] Fix appearance of handler in number input [Bug] Fix appearance of spinner buttons in number input Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-01-15 11:53:44 UTC
Commit: 45e0878

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen self-assigned this Jan 15, 2025
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review January 15, 2025 11:52
petar-qb
petar-qb approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix! 🏅

antonymilne
antonymilne approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

nadijagraca
nadijagraca approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) January 15, 2025 12:36
@huong-li-nguyen huong-li-nguyen merged commit 6633916 into main Jan 15, 2025
35 of 36 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/fix-removal-of-number-input branch January 15, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadijagraca nadijagraca nadijagraca approved these changes

@petar-qb petar-qb petar-qb approved these changes

@antonymilne antonymilne antonymilne approved these changes

@Joseph-Perkins Joseph-Perkins Awaiting requested review from Joseph-Perkins Joseph-Perkins is a code owner

@maxschulz-COL maxschulz-COL Awaiting requested review from maxschulz-COL maxschulz-COL is a code owner

@lingyielia lingyielia Awaiting requested review from lingyielia lingyielia is a code owner

Assignees

@huong-li-nguyen huong-li-nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huong-li-nguyen @antonymilne @petar-qb @nadijagraca